Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of code properties/modifier columns vs. chaining in the single code field should be standardized. #16

Open
mmcdermott opened this issue Jun 13, 2024 · 0 comments
Labels
MEDS-Extract Pipeline Configuration and Stage Management Issues relating to proper definition and usability of different stages in a pipeline priority:low A low priority issue. Release Blocking
Milestone

Comments

@mmcdermott
Copy link
Owner

mmcdermott commented Jun 13, 2024

Using separate columns throughout likely makes the most sense, though this would necessitate a (trivial) change to ACES and a (nontrivial) change to MEDS-Tab (in particular, the latter would need to collapse the codes first into some sort of delimited string, like we do now by default with "//", first to work correctly, I think).

Related ACES issue: justin13601/ACES#87
Related MEDS Tab issue: mmcdermott/MEDS_Tabular_AutoML#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEDS-Extract Pipeline Configuration and Stage Management Issues relating to proper definition and usability of different stages in a pipeline priority:low A low priority issue. Release Blocking
Projects
None yet
Development

No branches or pull requests

1 participant