Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"start" optional parameter for video embeds #2073

Closed
maxime-michel opened this issue Mar 3, 2019 · 2 comments
Closed

"start" optional parameter for video embeds #2073

maxime-michel opened this issue Mar 3, 2019 · 2 comments

Comments

@maxime-michel
Copy link
Contributor

I'd like to be able to start a video at a certain timestamp through an optional parameter, named start for instance. Both Vimeo and YouTube embed options allow this by adding a parameter such as t=1m2s.

I can submit a PR but I'm not sure if this is a common need. Any thoughts?

@mmistakes
Copy link
Owner

mmistakes commented Mar 3, 2019

To avoid further complicating things, not sure this is necessary. The time start is part of the video's URL. Couldn't you just append that to the video id and do something like this?

{% include video id="XsxDH4HcOWA?start=35" provider="youtube" %}

Perhaps just an update to the documentation to note that an id can contain the start time from a YouTube embed.

@maxime-michel
Copy link
Contributor Author

Excellent idea, that works great, thanks a lot. I'll open a PR to have it mentioned it in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants