Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High resolution screenshots? #2363

Closed
rodrigograca31 opened this issue Jan 5, 2020 · 8 comments
Closed

High resolution screenshots? #2363

rodrigograca31 opened this issue Jan 5, 2020 · 8 comments

Comments

@rodrigograca31
Copy link
Contributor

Suggestion

Hi.

I think you guys should use higher resolution images for the Skins (color variations)....
I understand they are there just to show the color difference but annoyed me to see crappy resolution when opening the images on a new tab....
Example here

If anyone can provide me with the sample posts used on the original images I will happily send a PR with high resolution screenshots for all the color variations.

@mmistakes
Copy link
Owner

mmistakes commented Jan 7, 2020

The originals don't exist any more. But if you want to create some new ones at a higher resolution I'd be cool with that.

When I created the screenshots originally for all of the skins I followed this workflow:

  1. Pull down mmistakes/minimal-mistakes
  2. cd test
  3. bundle install
  4. bundle exec jekyll serve
  5. Grab screenshot of the home page
  6. Start Jekyll server.
  7. Change minimal_mistakes_skin: in /test/_config.yml file, restart Jekyll server, grab screenshot..
  8. Rinse and repeat.

@rodrigograca31
Copy link
Contributor Author

but that wouldnt have any content right?

is that ok?

@mmistakes
Copy link
Owner

It should have content if you follow the steps above. The /test folder is a complete Jekyll site I use for debugging and testing all of its features.

If you jekyll build that you will get a full site with archives, home page, posts, collections, etc. Its the same content I used to grab the skin screenshots in the docs.

@rodrigograca31
Copy link
Contributor Author

oh! didnt noticed the test folder :)

@rodrigograca31
Copy link
Contributor Author

I have the images but couldn't find the the original folder where they are for example:
https://mmistakes.github.io/minimal-mistakes/assets/images/air-skin-archive.png

and I can't find the assets/images folder so I will leave the images here and hopefully you can update them?

sunrise
plum
mint
neon
dirt
dark
contrast
aqua
air

@mmistakes
Copy link
Owner

They go in /docs/assets/images/

And looking in that folder I have larger versions already. I believe I linked up the smaller versions in the README as it was wasteful to load the larger ones.

The better solution would be to show the small version, link to the large one. Something like this:

[![air skin](https://mmistakes.github.io/minimal-mistakes/assets/images/air-skin-archive.png)](https://mmistakes.github.io/minimal-mistakes/assets/images/air-skin-archive-large.png)

Would yield this:

air skin

@rodrigograca31
Copy link
Contributor Author

rodrigograca31 commented Jan 9, 2020

oh! the docs folder! I forgot!
I noticed it was a github page and I was looking for gh-pages branch but they had "versions" and I got confused .... 😂

Should we just update the links to the large version like you said or also update the images with my new ones? (I just noticed mine have the left bar "repeated" .... the extension sucks.... 😂 )

@mmistakes
Copy link
Owner

mmistakes commented Jan 13, 2020

Let's update the links to the large versions and go from there. Wish I had remembered sooner that I had the 2x images in that folder. Would have saved you some time.

jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this issue Jul 8, 2020
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this issue Jan 4, 2021
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this issue Sep 4, 2023
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants