jekyll 4.2.0 stopped overriding site.url, breaks lunr search result

[iveney]

Originally posted here. After a bit of search, I think this is probably because Jekyll stopped overriding site.url

Additionally, we have stopped overriding the site.url to http://localhost:4000 in absolute URLs while developing via jekyll serve.

Environment

• Minimal Mistakes version: 4.21.0
• Ruby gem or remote theme version:
• Jekyll version: 4.2.0
• Git repository URL: https://github.com/iveney/ivansiu.com/tree/upgrade-jekyll
• GitHub Pages hosted (if yes provide URL to site): www.ivanxiao.com
• Operating system: Mac OS Catalina

Expected behavior

In local deve (jekyll serve), clicking the search icon and type something, returned result should have proper URL as "http://localhost:4000/path". But now it is using site.url.

Steps to reproduce the behavior

• Clone my gh page repo here
• run bundle exec jekyll serve, open localhost:4000, click search and type something. Observe link is incorrect:

Other

[mmistakes]

Closing as this isn't a theme issue, Jekyll 4.2.0 changed the behavior of when it overrides site.url.

https://jekyllrb.com/news/2020/12/14/jekyll-4-2-0-released/

[iveney]

@mmistakes What's the reason to use absolute_url instead of relative_url in lunr-store.js though? Switching to relative_url seems fixing it for me (and compatible for older Jekyll).

As in other places such as archive-single.html I am seeing the<a/> is being added with {{ post.url | relative_url }} instead of absolute_url.