Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-English characters being url encoded in breadcrumb #3819

Merged

Conversation

boh5
Copy link
Contributor

@boh5 boh5 commented Jul 30, 2022

This is a bug fix.

Summary

Non-English characters being url encoded in breadcrumb navigation.
I added url_decode filter in breadcrumb navigation link text to fix that

Context

Tis related to my discussion #3816

Copy link

@silvio2402 silvio2402 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dilless, thank you for taking your time to contribute to the minimal-mistakes theme.
Your change looks good to me, however, you can remove the | replace: '%20', ' ' because %20 is now being url decoded anyways.

@boh5 boh5 closed this Aug 16, 2022
@boh5 boh5 reopened this Aug 16, 2022
@boh5
Copy link
Contributor Author

boh5 commented Aug 16, 2022

@silvio2402, thank for your checking. I have removed | replace: '%20', ' ' in the latest commit

@iBug iBug merged commit 2c92d34 into mmistakes:master Apr 22, 2024
minyoongi96 pushed a commit to minyoongi96/minyoongi96.github.io that referenced this pull request Aug 26, 2024
…#3819)

* Fix non-English characters being url encoded in breadcrumb

* Remove `| replace: '%20', ' ‘`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants