Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflows security hardening #3884

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

sashashura
Copy link
Contributor

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
@sashashura
Copy link
Contributor Author

Please let me know if you have any questions.

@sashashura
Copy link
Contributor Author

@iBug @mmistakes could you please review it?

@sashashura
Copy link
Contributor Author

An example of a recent workflow run with unrestricted permissions:
image

@iBug
Copy link
Collaborator

iBug commented Dec 1, 2022

This looks good to me, but I'm afraid @mmistakes isn't going to respond anytime soon. I haven't seen him online for a few months, and I don't have the access to merge this.

@sashashura
Copy link
Contributor Author

Thanks for letting me know. I hope he's ok!

@iBug iBug merged commit a179735 into mmistakes:master Apr 23, 2024
minyoongi96 pushed a commit to minyoongi96/minyoongi96.github.io that referenced this pull request Aug 26, 2024
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants