The "if" means the default is never used #4955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
Fixes the social share include so the default text works as expected.
Context
The current code looks like this:
The
if
statement means that the default ("Share on") is never used. And I assume that's what most people would want to see.Also, without the
<h4>
, we get a HTML validation warning - as the<section class="page__share">
has no header.Just removing the
if
/endif
lines fixes these problems without changing the behaviour.