Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greedy nav not working in Chrome for Mac or iOS. #932

Closed
2 of 5 tasks
twhite96 opened this issue Apr 4, 2017 · 4 comments
Closed
2 of 5 tasks

Greedy nav not working in Chrome for Mac or iOS. #932

twhite96 opened this issue Apr 4, 2017 · 4 comments

Comments

@twhite96
Copy link

twhite96 commented Apr 4, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

  • Minimal Mistakes version:
    4.3.1
  • github-pages or jekyll gem version:
    jekyll -v 3.4.3
  • Operating system:
    macOS 10.12.4

Expected behavior

Greedy nav appears then disappears, Chrome 57, desktop and on iOS 10.3

Steps to reproduce the behavior

Repo: https://github.com/twhite96/twhite96.github.io

Describe the steps you took for this problem to exist. Such as you cloned the theme, customized _config.yml, added your own posts, and started up a Jekyll server locally.
I've added some custom js with Bigfoot which doesn't seem to be the issue, I don't think. It worked when I first added it.

If an error occurred on GitHub Pages when pushing, please build locally and provide a complete log by running bundle exec jekyll --trace --verbose and including this output in the filed issue.

Screenshots can also be included if they help illustrate a behavior.

Dev Tools:

screenshot2017-04-04_01-28-50_am

If you notice it has hidden button count as "0". Not sure why.

iPhone Nav:

file apr 04 1 29 17 am

@mmistakes
Copy link
Owner

Try updating the theme to the latest. According to the source you're on a much older version.

For example in your HTML source I see this which tells me parts of your site are using outdated files:

<!doctype html>
<!--
  Minimal Mistakes Jekyll Theme 4.2.2 by Michael Rose
  Copyright 2017 Michael Rose - mademistakes.com | @mmistakes
  Free for personal and commercial use under the MIT license
  https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE.txt
-->

CSS and JS are that way too. Probably something is out of sync when you customized the scripts and stylesheets to add Lunr search and BigFoot.

If you look at the demo site you'll see how the source and various assets have the version number printed at the top.

HTML source:

<!--
  Minimal Mistakes Jekyll Theme 4.3.1 by Michael Rose
  Copyright 2017 Michael Rose - mademistakes.com | @mmistakes
  Free for personal and commercial use under the MIT license
  https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE.txt
-->

Main CSS source:

/*!
 * Minimal Mistakes Jekyll Theme 4.3.1 by Michael Rose
 * Copyright 2017 Michael Rose - mademistakes.com | @mmistakes
 * Licensed under MIT (https://github.com/mmistakes/minimal-mistakes/blob/master/LICENSE.txt)
*/

Main JavaScript source:

/*!
 * Minimal Mistakes Jekyll Theme 4.3.1 by Michael Rose
 * Copyright 2017 Michael Rose - mademistakes.com | @mmistakes
 * Licensed under MIT
 */

I'd suggest either backtracking what changes you made and comparing against the MM repo. I recently rebuilt the greedy nav so these commits are a good place for you start comparing against.

@twhite96
Copy link
Author

My problem is that I used the gem on GitHub pages. I didn't know you couldn't do that so every time I update the site on another server, it still has the GitHub Pages version I used. Anyway to fix this without blowing up my site?

@mmistakes
Copy link
Owner

The Ruby gem bundles in _layouts, _includes, _sass, assets/css/main.scss, and assets/js. If you're using the theme as a gem then you have no need for those files and they can be removed.

If you keep them they will override the ones bundled in the gem which is probably why things aren't working. Just keep the files you specifically customized, but make sure they have any upstream updates as well.

Other than that I don't really have any other advice.

@twhite96
Copy link
Author

Fixed. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants