Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Brazilian Portuguese translation #1275

Closed
wants to merge 1 commit into from
Closed

Improve Brazilian Portuguese translation #1275

wants to merge 1 commit into from

Conversation

lucascaton
Copy link
Contributor

No description provided.

@mmistakes
Copy link
Owner

Is this an improvement over what was done in #824? I'm not familiar with the language to know which reads better. There have been several PR's for this same change and just trying to figure out if this is just a "preference" or if one version is grammatically better.

@mmistakes
Copy link
Owner

Trying to avoid accepting PR's were people keep changing the string to read how they think it should, which seems to be the case with all of the previous PR's.

@lucascaton
Copy link
Contributor Author

lucascaton commented Sep 25, 2017 •
edited
Loading

Hi @mmistakes, thanks for having a look at this.

The PR you mentioned is pretty much the same, so I'll close mine.
However, that was merged into develop branch, is it going to be merged into master soon?

Thank you.

@lucascaton lucascaton closed this Sep 25, 2017
@lucascaton lucascaton deleted the patch-1 branch September 25, 2017 21:22
@mmistakes
Copy link
Owner

mmistakes commented Sep 25, 2017 •
edited
Loading

It should have been merged intomaster. Will have to investigate why it wasn't.

If you had time there are a few text strings that are in need of translating if you wanted to submit a PR.

@lucascaton
Copy link
Contributor Author

@mmistakes sure thing! #1278

okitem pushed a commit to okmalls/okmalls.github.io that referenced this pull request Mar 9, 2024
@cotes2020
perf(pwa): enhance cache privacy protection (mmistakes#1275)
2d56597 
Hiding the time zone of the build machine enhances privacy protection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Feedback Needed Status: Under Consideration Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucascaton @mmistakes