Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overlay and revert X to hamburger icon when popup disappears #3958

Merged
merged 1 commit into from
May 5, 2024

Conversation

ddomdel
Copy link
Contributor

@ddomdel ddomdel commented Oct 19, 2022

This is a bug fix.

Summary

image

The pop up menu above disappears after you move the cursor out of it. However, the white overlay on the screen does not disappear, as well as the x nav button on the top-right, remains as is.

Now when you click anywhere on the screen, the popup appears again, and the x nav button turns back to a hamburger menu button.
And when you click on the hamburger menu, the popup disappears.

The functionality is now behaving in the exact opposite that we want to.

To remedy this, once the popup disappears the x nav button should also return back to normal (hamburger button)

This commit fixes this issue.

Context

This is a direct pull request. No related Github issue

the `.hidden-links` popup disappears after you move the cursor out of it.
However, the white overlay on the screen does not disappear, as well as the `x` nav button on the top-right, remains as is.
Now when you click anywhere on the screen the popup appears again, and the `x` nav button turns back to a hamburger menu button.

And when you click on the hamburger menu, the popup disappears. now it's happening the exact opposite.

To remedy this, the pop up menu as well as the `x` nav button should also return back to normal once the popup disappears.

This commit fixes this issue.
@iBug
Copy link
Collaborator

iBug commented Oct 21, 2022

No changes?

@iBug iBug force-pushed the revert-1-remove-overlay-with-popup branch from 31e5be6 to 6864aee Compare May 5, 2024 09:28
@iBug iBug merged commit 16103c6 into mmistakes:master May 5, 2024
1 check passed
minyoongi96 pushed a commit to minyoongi96/minyoongi96.github.io that referenced this pull request Aug 26, 2024
…mistakes#3958)

the `.hidden-links` popup disappears after you move the cursor out of it.
However, the white overlay on the screen does not disappear, as well as the `x` nav button on the top-right, remains as is.
Now when you click anywhere on the screen the popup appears again, and the `x` nav button turns back to a hamburger menu button.

And when you click on the hamburger menu, the popup disappears. now it's happening the exact opposite.

To remedy this, the pop up menu as well as the `x` nav button should also return back to normal once the popup disappears.

This commit fixes this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants