Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add image helper for easier image insertion in posts #572

Closed
wants to merge 4 commits into from
Closed

add image helper for easier image insertion in posts #572

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eedf838
add image helper for easier image insertion in posts
fa-ribeiro Oct 7, 2016
37d4eb8
Update image
fa-ribeiro Nov 5, 2016
637e5d9
Replace base_path with `absolute_url` filter
fa-ribeiro Nov 5, 2016
da95259
Do not assume images would be placed in `/assets/images/`
fa-ribeiro Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions _includes/image
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<figure class="{{ include.class }}">
<img src=
{% if include.image_path contains "://" %}
"{{ include.image_path }}"
{% else %}
"{{ include.image_path | prepend: "/assets/images/" | absolute_url }}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor thing. With the latest MM I moved away from assuming images would be placed in /assets/images/ and instead encourage adding the full path. Adds more flexibility to where they can be placed for the user.

If you could remove prepend: "/assets/images/" it fall in line with the other helpers and I can merge it in.

{% endif %}
alt="{% if include.alt %}{{ include.alt }}{% endif %}">
{% if include.caption %}
<figcaption>{{ include.caption | markdownify | remove: "<p>" | remove: "</p>" }}</figcaption>
{% endif %}
</figure>