Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobStatus::isFinished() never returns true #93

Open
codecowboy opened this issue Mar 20, 2014 · 2 comments
Open

JobStatus::isFinished() never returns true #93

codecowboy opened this issue Mar 20, 2014 · 2 comments
Labels

Comments

@codecowboy
Copy link
Contributor

This code never evaluates to true as getCompletionPercent() will not usually return 1 unless you happen to request jobstatus at the exact moment it hits 1.

    public function isFinished()
    {
        return $this->isKnown() && !$this->isRunning() && $this->getCompletionPercent() == 1;
    }
@mmoreram
Copy link
Owner

What do you propose?

@mmoreram
Copy link
Owner

mmoreram commented Apr 2, 2014

ping @codecowboy

@mmoreram mmoreram added the issue label Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants