Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphere::Pdf does not return zero when wi points away from the sphere. #319

Open
GaryHuan9 opened this issue Feb 3, 2022 · 0 comments
Open

Comments

@GaryHuan9
Copy link

Thank you so much for the great book!

In chapter 14.2.2 Sampling Shapes, the second overload of Shape::Pdf returns 0 if wi does not intersect with the shape, which conceptually make sense. However, when Sphere::Pdf overrides this method, its implementation never returns 0 if the second (general sphere PDF) path is chosen, even if wi points away from the sphere. Is this a missed case in the code, or am I misunderstanding something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant