Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] hide message signature #166

Open
azjezz opened this issue Apr 10, 2021 · 4 comments
Open

[feature-request] hide message signature #166

azjezz opened this issue Apr 10, 2021 · 4 comments

Comments

@azjezz
Copy link

azjezz commented Apr 10, 2021

when an email is signed, it would be nice if externals.io would hide the signature, the header, and displaying only the content, but also adding a label/button at the top so people can still retrieve the signature to verify the message.

  • if message contains a signature
    • remove header
    • remove signature
    • add a label "Signed" at the top next to the author name.
    • when the label is clicked, the user should be redirect to a new page ( e.g email/114014/signature )
    • the new page should include:
      • the message content as is ( not render, with the signature attached )

BEFORE

image

AFTER

image

@azjezz
Copy link
Author

azjezz commented Apr 10, 2021

GitHub signed commit label:

image

@mnapoli
Copy link
Owner

mnapoli commented Apr 10, 2021

Hi!

I would suggest instead:

  • hide the signature entirely
  • people that want to retrieve the signature can click "View source"

I don't see the use case for knowing that an email is signed in the context of externals.io.

@azjezz
Copy link
Author

azjezz commented Apr 10, 2021

I think the issue is that source content is always broken to 75 bytes max using "=\n". ( see https://externals.io/email/114014/source )

which mean you cannot verify it by simply copy pasting.

The raw message page containing signature should probably use the result from $parsedDocument->getTextContent() ( see https://github.com/mnapoli/externals/blob/master/src/EmailSynchronizer.php#L110 )

If you approve of this feature, I will start working on an implementation tomorrow :)

@mnapoli
Copy link
Owner

mnapoli commented Apr 11, 2021

The raw message page containing signature should probably use the result from […]

The raw message page should contain the raw message body, I don't think it should contain any transformed data.

And since I don't know of a use case for checking email signatures (on externals.io), I don't see a reason to change anything to support verifying signatures. Maybe you know about some use cases I'm not aware of?

Separately from that, I agree that we can improve the readability of threads by hiding/removing signatures in threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants