-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All EEG and EOG channels have type 'ecg' when reading HCP data using read_raw_bti() #10988
Comments
@ckiefer0 can you share a problematic file with me? |
For the
If I do:
I get:
so at least the ECG channels seem to be named correctly if you pass For the others that are clearly something else (I think!), I've opened #11102 . I think that covers what we need to change in MNE-Python, but let me know if you disagree @ckiefer0 ! |
@larsoner The changes in #11102 look good. I just have one question: Why are the two ECG channels renamed from ECG+ and ECG- to EEG 001 and EEG 004 when using rename_channels=True? Isn't ECG+ and ECG- much more meaningful especially since the EOG channels get to keep their names. PS: I wasn't sure whether to reply here or in #11102. |
This seems like a bug. Want to try fixing it? It seems like only channels marked as EEG should get renamed using EEG names. The EOG ones should probably be EOG 001..., ECG as ECG 001..., etc. |
I see. But why not keep the +/- naming? Then it would be immediately clear that there is a cathode/anode pair and for EOG you would immediately know whether it is a vertical or horizontal channel. Furthermore, it would help with compatibility with mne-hcp since one could use the following mne-hcp.preprocessing function without any further renaming:
|
The idea behind Personally I would use |
This bug report is based on this discussion in the MNE group.
I am using MNE and MNE-HCP to analyze HCP data. When I use the following function to read the HCP data, all ECG, EOG, and EEG channels have type 'ecg':
The same also happens when I simply use hcp.read_raw(). Here are the info files for the two variants.
mne.io.read_raw_bti:
hcp.read_raw:
Furthermore, when using mne.io.read_raw_bti(), the ECG+ and ECG- channels are not named correctly anymore. I am currently using these functions as a workaround:
Versions:
MNE-HCP: 0.1.dev12
MNE: 1.03
The text was updated successfully, but these errors were encountered: