BUG: Fix bug extracting meas_date #10277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is crazy! And what about all other locales? Like, there must be dozens more? |
|
Yes, there are many, many more locales. But we can deal with that later if we need to |
|
let's move on here. thx @larsoner |
|
Thanks @larsoner! |
|
Awesome! Thanks @larsoner |
|
Hi @larsoner,
thank you for this answer but I am not sure to have understood how to go on.
should I find these files (latest.inc,config.py and so on) on my laptop and replace with the codes in the links that you shared with me?
What should I do with patch links?
Thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy
… On 31 Jan 2022, at 19:52, Eric Larson ***@***.***> wrote:
mne/io/nirx/tests/test_nirx.py <https://github.com/mne-tools/mne-python/pull/10277/files#diff-3fda559feb3fb4c8d2fcb27653b2abf70d19baa18c992bc58721256693d57060>
|
|
The easiest thing to do now that this has been merged is something like it will install the latest version of the |
|
Thank you, it worked.
Is it possible after some MNE processing (like corrected_raw = temporal_derivative_distribution_repair(raw_od)
) to save again the file in nirx format.
I am searching a command like mne.io.read_raw_nirx but to export the file.
Tank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy
… On 2 Feb 2022, at 18:43, Eric Larson ***@***.***> wrote:
The easiest thing to do now that this has been merged is something like
pip install --upgrade https://github.com/mne-tools/mne-python/zipball/main
it will install the latest version of the main branch (1.0.dev0), where this PR was merged.
—
Reply to this email directly, view it on GitHub <#10277 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW6ZCD3JI7XDHTQAAVDYBVDUZFUKTANCNFSM5NHCPFLQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
|
Not to NIRx, but you could try writing to SNIRF using MNE-NIRS |
|
Dears,
Is it possible to add the feature to export processed data into nirx?
That would be awesome,
Thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy
… On 15 Feb 2022, at 17:11, Eric Larson ***@***.***> wrote:
Not to NIRx, but you could try writing to SNIRF using MNE-NIRS
https://mne.tools/mne-nirs/generated/mne_nirs.io.snirf.write_raw_snirf.html#mne_nirs.io.snirf.write_raw_snirf <https://mne.tools/mne-nirs/generated/mne_nirs.io.snirf.write_raw_snirf.html#mne_nirs.io.snirf.write_raw_snirf>
—
Reply to this email directly, view it on GitHub <#10277 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW6ZCD4Q6V35PH4OHB6BM23U3J3MRANCNFSM5NHCPFLQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
|
Hi @mlrocca, Exporting as nirx format is not something that is planned. The nirx format has been superseded by SNIRF as larsoner mentioned. New NIRX devices actually export as SNIRF natively now. Further, the nirx format is not documented and does not support exporting as OD or haemoglobin. |
|
Thank you,
it makes totally sense.
Then, I will try to continue to use MNE also for the analyses. I really like MNE but I am not really familiar with that.
I would need to define contrast and find statistical differences between two groups patients and controls during finger tapping task. Is there a tutorial to do this? I found how to analyze the differences between two conditions here
https://mne.tools/mne-nirs/auto_examples/general/plot_12_group_glm.html#sphx-glr-auto-examples-general-plot-12-group-glm-py <https://mne.tools/mne-nirs/auto_examples/general/plot_12_group_glm.html#sphx-glr-auto-examples-general-plot-12-group-glm-py>
but I can’t find group level analyses between two groups.
Could you help me?
Thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy
… On 17 Feb 2022, at 01:20, Robert Luke ***@***.***> wrote:
Hi @mlrocca <https://github.com/mlrocca>,
Exporting as nirx format is not something that is planned. The nirx format has been superseded by SNIRF as larsoner mentioned. New NIRX devices actually export as SNIRF natively now. Further, the nirx format is not documented and does not support exporting as OD or haemoglobin.
—
Reply to this email directly, view it on GitHub <#10277 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW6ZCD334LP3IDIEE7AJZTTU3Q5NLANCNFSM5NHCPFLQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
larsoner
referenced
this pull request
in mne-tools/mne-testing-data
Feb 17, 2022
|
@mlrocca this sounds more like a usage question, and we try to stick to code bugs and enhancement requests on GitHub. Could you please post your question to https://mne.discourse.group/ instead? |
|
Of course,
thank you,
Marianna La Rocca, PhD
Assistant Professor in Applied Physics
Dipartimento Iterateneo di Fisica M. Merlin
Università degli Studi di Bari A. Moro
Via Amendola 173 - 70125 Bari, Italy
… On 17 Feb 2022, at 12:57, Eric Larson ***@***.***> wrote:
@mlrocca <https://github.com/mlrocca> this sounds more like a usage question, and we try to stick to code bugs and enhancement requests on GitHub. Could you please post your question to https://mne.discourse.group/ <https://mne.discourse.group/> instead?
—
Reply to this email directly, view it on GitHub <#10277 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AW6ZCD2WKZMPTQTTW4HP4FLU3TPENANCNFSM5NHCPFLQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10147
Turns out that localized dates is a pain in Python, and solving it in a general way requires a lot of work and/or additional dependencies. This implements a simpler solution: use a script to make a dict of translations and try them all. It's quick to execute, and easy enough to generate the dict of translations that we need.
@mlrocca feel free to try this branch (or just wait until it's merged into
mainand try that), it should fix your bug.@rob-luke feel free to review and merge if you're happy