MRG: Add fnirs and snirf support to report #9443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems reasonable to me |
3 tasks
Well in that case, @larsoner @agramfort could you please review? Maybe relevant to @hoechenberger too. |
rob-luke
changed the title
larsoner
reviewed
Jun 5, 2021
agramfort
approved these changes
Jun 6, 2021
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue as a PR, I have opened this for discussion.
What does this implement/fix?
Allows
to read fNIRS files stored with the pattern
*-nirs.snirfas defined in the draft BIDS standard https://bids-specification--802.org.readthedocs.build/en/802/04-modality-specific-files/10-functional-near-infrared-spectroscopy.html#fnirs-recording-dataAdditional information
It seems report is currently used with fiff files, are we open to extending it to other file types?
Allowing the file pattern above will facilitate reading files in the BIDS format. The fNIRS BIDS specification has moved from a community feedback stage to draft proposal: bids-standard/bids-specification#802 However, its not finalised (as I am the BEP lead it is extremely unlikely this file pattern will change, but I am trying to think of all possible issues here).