Add BBUncrustifyPlugin

[keith]

From https://github.com/benoitsan/BBUncrustifyPlugin-Xcode

[supermarin]

This one isn't ready to be merged yet, as it's install path is different than project name.
We'd need to either parse .xcodeproj or work with .xcplugins.

Or something better :)

[benoitsan]

Do you mean the issue is because the plugin package name is 'UncrustifyPlugin.xcplugin' and the Xcode project is 'BBUncrustifyPlugin-Xcode' ?

[kattrali]

Yep.

[benoitsan]

I made a try. The plugin is correctly installed in the plugins folder with the correct name but is not marked as installed. So I suppose it's the issue you are talking about: you are using the Xcode project name as the key to find the corresponding plugin.

Because an Xcode project can contain one or more targets and because the Xcode project name can be different from the target, an idea would be to add a key in the plugin definition in packages.json to specify the target product name.

It could be something like that:

{
    "name": "BBUncrustifyPlugin",
    "url": "https://github.com/benoitsan/BBUncrustifyPlugin-Xcode",
    "description": "Xcode plugin to uncrustify the source code opened in the editor"
    "product name": "UncrustifyPlugin"
}

Or perhaps better in order to manage the case where there are multiple targets
PS: Supposing that the target name is the only information needed to build the target using /usr/bin/xcodebuild

{
    "name": "BBUncrustifyPlugin",
    "url": "https://github.com/benoitsan/BBUncrustifyPlugin-Xcode",
    "description": "Xcode plugin to uncrustify the source code opened in the editor"
    "target": {
        "name" : "BBUncrustifyPlugin",
        "product name" : "UncrustifyPlugin"
    }
}

[supermarin]

@benoitsan thanks for sharing that.

The only concern in this approach is that it could make JSON over-complex, and make it a bit harder for people adding packages.

Since this information could be parsed easily, I've added some basic support here: mneorr/Alcatraz@19b7591

For the case of many targets, I guess there should always be a default target which would be used by just running xcodebuild - and that one would be used by Alcatraz.

[supermarin]

@Keithbsmiley could you please rebase on master and we're ready to 🚢

[keith]

Think we're good now

[orta]

woop 🌠