Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track failed tx proposals in consensus #3208

Merged
merged 9 commits into from
Apr 8, 2023
Merged

Track failed tx proposals in consensus #3208

merged 9 commits into from
Apr 8, 2023

Commits on Apr 8, 2023

  1. Track failed tx proposals in consensus

    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    7bb469e View commit details
    Browse the repository at this point in the history

  2. Push an Instant::now() for every time validation fails on a tx proposal

    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    f70ce5a View commit details
    Browse the repository at this point in the history

  3. Fix unnecessary .clone()

    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    91849a4 View commit details
    Browse the repository at this point in the history

  4. Cargo fmt

    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    7e64444 View commit details
    Browse the repository at this point in the history

  5. Return to tracking clients as soon as they submit a proposeTX, per Ja… 

    …mes' suggestion
    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    d8b4e4c View commit details
    Browse the repository at this point in the history

  6. Cargo fmt

    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    dac0abe View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Sam Dealy <33067698+samdealy@users.noreply.github.com>
    @NotGyro @samdealy
    NotGyro and samdealy committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    dfece1e View commit details
    Browse the repository at this point in the history

  8. Respond to suggestions on the pull request, no longer using reference… 

    …s for Instant and Duration
    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    1a6bc0b View commit details
    Browse the repository at this point in the history

  9. Merge in suggested changes

    @NotGyro
    NotGyro committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    13376da View commit details
    Browse the repository at this point in the history