From 9d98af90e3567ecd0aa23caab518816f23f0712c Mon Sep 17 00:00:00 2001
From: hhhjort <31041505+hhhjort@users.noreply.github.com>
Date: Mon, 26 Apr 2021 10:41:02 -0400
Subject: [PATCH] AppNexus: reform bid floor handling (#1814)

---
 adapters/appnexus/appnexus.go                 |   2 +-
 .../supplemental/reserve-ignored.json         | 144 ++++++++++++++++++
 .../supplemental/reserve-test.json            | 143 +++++++++++++++++
 3 files changed, 288 insertions(+), 1 deletion(-)
 create mode 100644 adapters/appnexus/appnexustest/supplemental/reserve-ignored.json
 create mode 100644 adapters/appnexus/appnexustest/supplemental/reserve-test.json

diff --git a/adapters/appnexus/appnexus.go b/adapters/appnexus/appnexus.go
index 046f5d312d7..4d4324c44de 100644
--- a/adapters/appnexus/appnexus.go
+++ b/adapters/appnexus/appnexus.go
@@ -495,7 +495,7 @@ func preprocess(imp *openrtb2.Imp, defaultDisplayManagerVer string) (string, err
 	if appnexusExt.InvCode != "" {
 		imp.TagID = appnexusExt.InvCode
 	}
-	if appnexusExt.Reserve > 0 {
+	if imp.BidFloor <= 0 && appnexusExt.Reserve > 0 {
 		imp.BidFloor = appnexusExt.Reserve // This will be broken for non-USD currency.
 	}
 	if imp.Banner != nil {
diff --git a/adapters/appnexus/appnexustest/supplemental/reserve-ignored.json b/adapters/appnexus/appnexustest/supplemental/reserve-ignored.json
new file mode 100644
index 00000000000..84e2b48484e
--- /dev/null
+++ b/adapters/appnexus/appnexustest/supplemental/reserve-ignored.json
@@ -0,0 +1,144 @@
+{
+    "mockBidRequest": {
+      "id": "test-request-id",
+      "imp": [
+        {
+          "id": "test-imp-id",
+          "banner": {
+            "format": [
+              {
+                "w": 300,
+                "h": 250
+              },
+              {
+                "w": 300,
+                "h": 600
+              }
+            ]
+          },
+          "bidfloor": 0.3,
+          "ext": {
+            "bidder": {
+              "placement_id": 1,
+              "reserve": 0.4
+            }
+          }
+        }
+      ]
+    },
+  
+    "httpCalls": [
+      {
+        "expectedRequest": {
+          "uri": "http://ib.adnxs.com/openrtb2",
+          "body": {
+            "id": "test-request-id",
+            "ext": {
+              "appnexus": {
+                "hb_source": 5
+              },
+              "prebid": {}
+            },
+            "imp": [
+              {
+                "id": "test-imp-id",
+                "banner": {
+                  "format": [
+                    {
+                      "w": 300,
+                      "h": 250
+                    },
+                    {
+                      "w": 300,
+                      "h": 600
+                    }
+                  ],
+                  "w": 300,
+                  "h": 250
+                },
+                "bidfloor": 0.3,
+                "ext": {
+                  "appnexus": {
+                    "placement_id": 1
+                  }
+                }
+              }
+            ]
+          }
+        },
+        "mockResponse": {
+          "status": 200,
+          "body": {
+            "id": "test-request-id",
+            "seatbid": [
+              {
+                "seat": "958",
+                "bid": [{
+                  "id": "7706636740145184841",
+                  "impid": "test-imp-id",
+                  "price": 0.500000,
+                  "adid": "29681110",
+                  "adm": "some-test-ad",
+                  "adomain": ["appnexus.com"],
+                  "iurl": "http://nym1-ib.adnxs.com/cr?id=29681110",
+                  "cid": "958",
+                  "crid": "29681110",
+                  "h": 250,
+                  "w": 300,
+                  "ext": {
+                    "appnexus": {
+                      "brand_id": 1,
+                      "brand_category_id": 1,
+                      "auction_id": 8189378542222915032,
+                      "bid_ad_type": 0,
+                      "bidder_id": 2,
+                      "ranking_price": 0.000000,
+                      "deal_priority": 5
+                    }
+                  }
+                }]
+              }
+            ],
+            "bidid": "5778926625248726496",
+            "cur": "USD"
+          }
+        }
+      }
+    ],
+  
+    "expectedBidResponses": [
+      {
+        "currency": "USD",
+        "bids": [
+          {
+            "bid": {
+              "id": "7706636740145184841",
+              "impid": "test-imp-id",
+              "price": 0.5,
+              "adm": "some-test-ad",
+              "adid": "29681110",
+              "adomain": ["appnexus.com"],
+              "iurl": "http://nym1-ib.adnxs.com/cr?id=29681110",
+              "cid": "958",
+              "crid": "29681110",
+              "w": 300,
+              "h": 250,
+              "cat": ["IAB20-3"],
+              "ext": {
+                "appnexus": {
+                  "brand_id": 1,
+                  "brand_category_id": 1,
+                  "auction_id": 8189378542222915032,
+                  "bid_ad_type": 0,
+                  "bidder_id": 2,
+                  "ranking_price": 0.000000,
+                  "deal_priority": 5
+                }
+              }
+            },
+            "type": "banner"
+          }
+        ]
+      }
+    ]
+  }
\ No newline at end of file
diff --git a/adapters/appnexus/appnexustest/supplemental/reserve-test.json b/adapters/appnexus/appnexustest/supplemental/reserve-test.json
new file mode 100644
index 00000000000..f5c6dfceb4f
--- /dev/null
+++ b/adapters/appnexus/appnexustest/supplemental/reserve-test.json
@@ -0,0 +1,143 @@
+{
+    "mockBidRequest": {
+      "id": "test-request-id",
+      "imp": [
+        {
+          "id": "test-imp-id",
+          "banner": {
+            "format": [
+              {
+                "w": 300,
+                "h": 250
+              },
+              {
+                "w": 300,
+                "h": 600
+              }
+            ]
+          },
+          "ext": {
+            "bidder": {
+              "placement_id": 1,
+              "reserve": 0.4
+            }
+          }
+        }
+      ]
+    },
+  
+    "httpCalls": [
+      {
+        "expectedRequest": {
+          "uri": "http://ib.adnxs.com/openrtb2",
+          "body": {
+            "id": "test-request-id",
+            "ext": {
+              "appnexus": {
+                "hb_source": 5
+              },
+              "prebid": {}
+            },
+            "imp": [
+              {
+                "id": "test-imp-id",
+                "banner": {
+                  "format": [
+                    {
+                      "w": 300,
+                      "h": 250
+                    },
+                    {
+                      "w": 300,
+                      "h": 600
+                    }
+                  ],
+                  "w": 300,
+                  "h": 250
+                },
+                "bidfloor": 0.4,
+                "ext": {
+                  "appnexus": {
+                    "placement_id": 1
+                  }
+                }
+              }
+            ]
+          }
+        },
+        "mockResponse": {
+          "status": 200,
+          "body": {
+            "id": "test-request-id",
+            "seatbid": [
+              {
+                "seat": "958",
+                "bid": [{
+                  "id": "7706636740145184841",
+                  "impid": "test-imp-id",
+                  "price": 0.500000,
+                  "adid": "29681110",
+                  "adm": "some-test-ad",
+                  "adomain": ["appnexus.com"],
+                  "iurl": "http://nym1-ib.adnxs.com/cr?id=29681110",
+                  "cid": "958",
+                  "crid": "29681110",
+                  "h": 250,
+                  "w": 300,
+                  "ext": {
+                    "appnexus": {
+                      "brand_id": 1,
+                      "brand_category_id": 1,
+                      "auction_id": 8189378542222915032,
+                      "bid_ad_type": 0,
+                      "bidder_id": 2,
+                      "ranking_price": 0.000000,
+                      "deal_priority": 5
+                    }
+                  }
+                }]
+              }
+            ],
+            "bidid": "5778926625248726496",
+            "cur": "USD"
+          }
+        }
+      }
+    ],
+  
+    "expectedBidResponses": [
+      {
+        "currency": "USD",
+        "bids": [
+          {
+            "bid": {
+              "id": "7706636740145184841",
+              "impid": "test-imp-id",
+              "price": 0.5,
+              "adm": "some-test-ad",
+              "adid": "29681110",
+              "adomain": ["appnexus.com"],
+              "iurl": "http://nym1-ib.adnxs.com/cr?id=29681110",
+              "cid": "958",
+              "crid": "29681110",
+              "w": 300,
+              "h": 250,
+              "cat": ["IAB20-3"],
+              "ext": {
+                "appnexus": {
+                  "brand_id": 1,
+                  "brand_category_id": 1,
+                  "auction_id": 8189378542222915032,
+                  "bid_ad_type": 0,
+                  "bidder_id": 2,
+                  "ranking_price": 0.000000,
+                  "deal_priority": 5
+                }
+              }
+            },
+            "type": "banner"
+          }
+        ]
+      }
+    ]
+  }
\ No newline at end of file