Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #675

Closed
drc38 opened this issue Nov 1, 2024 · 21 comments
Closed

New release #675

drc38 opened this issue Nov 1, 2024 · 21 comments
Assignees
Labels
bug Something isn't working

Comments

@drc38
Copy link
Contributor

drc38 commented Nov 1, 2024

@proelke are we able to get a new release to Pypi to include the changes since May please?

@drc38 drc38 added the bug Something isn't working label Nov 1, 2024
@jainmohit2001
Copy link
Collaborator

@proelke @mdwcrft, can we expedite this process?

@proelke
Copy link
Collaborator

proelke commented Nov 5, 2024

I am working on getting access to do so.

@jainmohit2001
Copy link
Collaborator

Hi @proelke, any significant updates here?

@mdwcrft
Copy link
Collaborator

mdwcrft commented Nov 15, 2024

Just catching up with this it looks like there's some clean up and testing to do with the latest 1.0.0 release and the 2.0.0-rc releases that were made. We'll talk to the old maintainers to check the status of all this then aim to release 2.0.0

@jainmohit2001
Copy link
Collaborator

Any updates guys? Can we plan the TODOs for 2.0.0?

@ajmirsky
Copy link
Contributor

ajmirsky commented Nov 25, 2024

@jainmohit2001 I have some bandwidth this week and next (an beyond) to help with the release and other contributions. There are two pull requests: one for the additional docs and another for matching datatypes with the jsonschema. I went through the issues, and lots were requests for information, which I'll have a moment to respond to later today.

Do you have a recommendation of other tickets or items that you need help with?

@ajmirsky
Copy link
Contributor

@mdwcrft can you enumerate the items that need clean up and testing for the 1.0.0 and the 2.0.0-rc releases. It'd help the community to contribute so we can continue improving on this great project!

@mdwcrft
Copy link
Collaborator

mdwcrft commented Dec 2, 2024

Maintainers will be having a call this Friday to assess the state of the releases and document steps to continue, I'll update here afterwards

@jainmohit2001
Copy link
Collaborator

jainmohit2001 commented Dec 7, 2024

I am laying down the tasks that should be completed before we go on to release the latest version.
Feel free to share your inputs here.

@ajmirsky
Copy link
Contributor

ajmirsky commented Dec 8, 2024

@jainmohit2001 The PR #688 should take care of item #2 on the list; it updates the publish-to-pypi.yaml workflow which, when triggered by whomever is releasing through the github ui or cli, will create the tag, release and push to pypi all based on the version in pyproject.toml

@ajmirsky
Copy link
Contributor

ajmirsky commented Dec 8, 2024

@jainmohit2001 @proelke @mdwcrft will any of the pending PRs be evaluated as part of the next release? specifically, many of us are waiting on #680 (and #684 should be included to verify no breaking changes).

@ajmirsky
Copy link
Contributor

ajmirsky commented Dec 8, 2024

@jainmohit2001 can you be more specific on what is remaining for #671 ? with PR #681 , I believe all of the required docs are now complete.

@jainmohit2001
Copy link
Collaborator

@jainmohit2001 The PR #688 should take care of item #2 on the list; it updates the publish-to-pypi.yaml workflow which, when triggered by whomever is releasing through the github ui or cli, will create the tag, release and push to pypi all based on the version in pyproject.toml

I'll consult with the admins to understand what kind of release flow should we go with.

@jainmohit2001
Copy link
Collaborator

@jainmohit2001 @proelke @mdwcrft will any of the pending PRs be evaluated as part of the next release? specifically, many of us are waiting on #680 (and #684 should be included to verify no breaking changes).

Will definitely include this. I'll go through all the changes once again.

@jainmohit2001
Copy link
Collaborator

@jainmohit2001 can you be more specific on what is remaining for #671 ? with PR #681 , I believe all of the required docs are now complete.

Need to update the information about supported versions. Will comment soon in the PR itself.

@mdwcrft
Copy link
Collaborator

mdwcrft commented Dec 9, 2024

@jainmohit2001 @proelke @mdwcrft will any of the pending PRs be evaluated as part of the next release? specifically, many of us are waiting on #680 (and #684 should be included to verify no breaking changes).

I'm preparing a 2.0.0 release today which may not include these but I can make another release this week with them once merged

@ajmirsky
Copy link
Contributor

ajmirsky commented Dec 9, 2024

@jainmohit2001 @mdwcrft @proelke while we're all eager for a new release, I think it better to be thorough about what should be included in an official 2.0 release and waiting another day or two to make sure things like unit tests, correct datatypes for ocpp 2.0 actions, etc are very important to include.

@mdwcrft
Copy link
Collaborator

mdwcrft commented Dec 9, 2024

I was aiming to release 2.0 today and then 3.0 with the other changes later this/next week but if consensus is that it's fine to wait for 2.0 we can do that

@drc38
Copy link
Contributor Author

drc38 commented Dec 9, 2024

I am laying down the tasks that should be completed before we go on to release the latest version. Feel free to share your inputs here.

Deprecated values in enums.py also need to be removed before the release. See #694

@drc38
Copy link
Contributor Author

drc38 commented Dec 9, 2024

Appreciate views on #506, the exceptions are an edge case and unlikely to occur in reality but it would be useful to have consensus and merge.

@drc38
Copy link
Contributor Author

drc38 commented Dec 17, 2024

Is there a timeline to confirm what's in 2.0.0 and to publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

5 participants