Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"He'll" being marked as profane word #6

Open
ngan opened this issue Oct 3, 2011 · 5 comments
Open

"He'll" being marked as profane word #6

ngan opened this issue Oct 3, 2011 · 5 comments
Labels

Comments

@ngan
Copy link

ngan commented Oct 3, 2011

Does it make sense for he'll to be marked as a profane word?

@adambair
Copy link
Contributor

adambair commented Oct 3, 2011

No, not at all. This is totally a bug. Is this new or has it always been this way -- I accepted a pull request which modified the dictionary which may have introduced this -- I'll check it out and see what's up.

@ngan
Copy link
Author

ngan commented Oct 3, 2011

I'm on gem version 0.0.2. Not sure if it's new or not.

@ghost ghost assigned adambair Oct 3, 2011
@adambair
Copy link
Contributor

adambair commented Oct 3, 2011

I released 0.1.1 last week, let me know if you still have trouble after the upgrade (or if need it to work in this specific version).

@ngan
Copy link
Author

ngan commented Oct 3, 2011

Yea, I saw the new versions, but haven't had time to upgrading. But I also noticed that two changes (from the two versions diff) doesn't touch the process of checking word's profanity at all. The problem is the regex: \W considers ' as non-word, so he'll gets turned into hell. I think the best thing is to use \s to swallow just spaces instead.

@ngan
Copy link
Author

ngan commented Nov 1, 2011

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants