bug: ES6 syntax "static variable async vs static variable = async"

[meabed]

Thanks for the update and maintaining the project.

In the last v6.0.0
Applying @Inject, static properties are not copied correctly if its defined in this syntax

@inject('store')
@observer
class Btn extends Component {
  // ❌ not working
  static async getInitialProps () {
    console.log("static");
  };
  render() {}
}

When you change it to variable based it works

@inject('store')
@observer
class Btn extends Component {
  // ✅this works
  static getInitialProps = async () => {
    console.log("static");
  };
  render() {}
}

My guess is the issue is in copyStaticProperties

Could you guys have a look at this as it breaks any components now.
I am using it in nextjs as reference here.

Thank you and keep up the awesome work 👍

[urugator]

https://github.com/mobxjs/mobx-react/blob/master/src/utils/utils.js#L69
Object.keys(base) has to be replaced by Object.getOwnPropertyNames(base) to include non-enumerables.
The check base.hasOwnProperty(key) is redundant, both .keys/.getOwnPropertyNames returns own props.

[meabed]

Yes, absolutely need to change, thanks for the suggestion 👍

[mweststrate]

PR welcome!

[meabed]

@mweststrate PR ready :) Thanks! #682

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.