Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

relax dependency on mobx-react-lite #775

Closed
mixtur opened this issue Sep 4, 2019 · 6 comments
Closed

relax dependency on mobx-react-lite #775

mixtur opened this issue Sep 4, 2019 · 6 comments

Comments

@mixtur
Copy link

mixtur commented Sep 4, 2019

currently we have two copies of mobx-react-lite in our app becuase of this dependency graph:

app->mobx-react (~6.1.3)->mobx-react-lite (1.4.0) //EXACT version
app->some-package->mobx-react-lite (~1.4.1)

Therefore we have in our build both mobx-react-lite@1.4.0 and mobx-react-lite@1.4.1

@pedro-mass
Copy link

Has this been resolved by 039b7db ?

It still not a relaxed dependency, so it'll resurface when the underlying package updates their inner-dependency. Maybe there's still work to see if the dependency can be switched to a ~?

@danielkcz
Copy link
Contributor

danielkcz commented Oct 2, 2019

Well, to be honest, I don't expect mobx-react-lite to have more 1.x versions. More likely 2.0 will come out soon-ish (mobxjs/mobx-react-lite#212) so we can relax dependency after that.

@mixtur
Copy link
Author

mixtur commented Oct 2, 2019

There could still be patches. No library is perfect.

@danielkcz
Copy link
Contributor

Yea well, given that 2.0 does not deliver any big breaking changes, I don't think we will support 1.x after 2.x is published.

@danielkcz
Copy link
Contributor

The lite 2.0 has been published some time ago and mobx-react 6.2.0 depends on it. Closing this.

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants