make sure computed() created properties use the correct name

mobxjs · Aug 31, 2016 · b73f24f · b73f24f
1 parent 2898717
commit b73f24f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/types/observableobject.ts b/src/types/observableobject.ts
@@ -82,9 +82,11 @@ export function defineObservableProperty(adm: ObservableObjectAdministration, pr
 
 	if (newValue instanceof ObservableValue) {
 		observable = newValue;
+		newValue.name = name;
 		isComputed = false;
 	} else if (newValue instanceof ComputedValue) {
 		observable = newValue;
+		newValue.name = name;
 		if (!newValue.scope)
 			newValue.scope = adm.target;
 	} else if (typeof newValue === "function" && newValue.length === 0 && !isAction(newValue)) {

diff --git a/test/extras.js b/test/extras.js
@@ -274,6 +274,7 @@ test('get debug name', function(t) {
 	var e = mobx.computed(() => 3);
 	var f = mobx.autorun(() => c.has('b'));
 	var g = new Clazz();
+	var h = mobx.observable({ b: function() {}, c: mobx.computed(function(){}) });
 
 	function name(thing, prop) {
 		return mobx.extras.getDebugName(thing, prop);
@@ -298,6 +299,9 @@ test('get debug name', function(t) {
 	t.equal(name(g), "Clazz@9");
 	t.equal(name(g, "a"), "Clazz@9.a");
 
+	t.equal(name(h, "b"), "ObservableObject@12.b");
+	t.equal(name(h, "c"), "ObservableObject@12.c");
+
 	f();
 	t.end();
 });