-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs #710
update docs #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/dockerfile_experimental.md
Outdated
``` | ||
|
||
```console | ||
$ buildctl build --frontend=dockerfile.v0 --local context=. --local dockerfile=. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add the docker build
example as well for now (not sure if img
supports it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we defer until Docker v18.09 GA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could just mention "(requires version v18.09+)"
updated |
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@@ -0,0 +1,129 @@ | |||
# Dockerfile frontend experimental syntaxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add another file that describes the dockerfile image release process? Something that could be linked from https://github.com/docker/cli/pull/1493/files#diff-4fc21624aa5dadd153e2780910da7c7dR304 . Eg. what releases happen to docker/dockerfile-upstream
, the features that produce nightly builds etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be a second PR.
This is a great first PR. I say let’s get it in. |
LGTM |
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp