Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs #710

Merged
merged 1 commit into from
Nov 1, 2018
Merged

update docs #710

merged 1 commit into from
Nov 1, 2018

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
```

```console
$ buildctl build --frontend=dockerfile.v0 --local context=. --local dockerfile=. \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add the docker build example as well for now (not sure if img supports it).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we defer until Docker v18.09 GA?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just mention "(requires version v18.09+)"

docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
docs/dockerfile_experimental.md Outdated Show resolved Hide resolved
docs/rootless.md Outdated Show resolved Hide resolved
@AkihiroSuda
Copy link
Member Author

updated

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@@ -0,0 +1,129 @@
# Dockerfile frontend experimental syntaxes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add another file that describes the dockerfile image release process? Something that could be linked from https://github.com/docker/cli/pull/1493/files#diff-4fc21624aa5dadd153e2780910da7c7dR304 . Eg. what releases happen to docker/dockerfile-upstream, the features that produce nightly builds etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be a second PR.

@tiborvass
Copy link
Collaborator

This is a great first PR. I say let’s get it in.

@tiborvass tiborvass merged commit 5aab829 into moby:master Nov 1, 2018
@tonistiigi
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants