Improve resilience of TestPullFromCentralRegistryImplicitRefParts #20411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes transient network issues will cause TestPullFromCentralRegistryImplicitRefParts to end up pulling with the v1 protocol. This violates the assumptions behind the test. To make the test more robust, allow a few retries if any pull ends up using the v1 protocol. Fixes moby#17214 Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
LGTM |
1 similar comment
|
LGTM |
calavera
added a commit
that referenced
this pull request
Feb 17, 2016
…ntralRegistryImplicitRefParts Improve resilience of TestPullFromCentralRegistryImplicitRefParts
calavera
deleted the
strengthen-TestPullFromCentralRegistryImplicitRefParts
branch
aaronlehmann
added a commit
to aaronlehmann/docker
that referenced
this pull request
Mar 2, 2016
Retries after v1 fallbacks were added in moby#20411. The test still appears to be flaky. There are two potential problems. The initial pull was not protected against pulling from v1, so it could be giving us a different hello-world image to compare against. Also, after experiencing a v1 fallback, we need to restore the original image before doing the next pull, because otherwise the "Image is up to date for hello-world:latest" message will not show up as expected. See moby#17214. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes transient network issues will cause
TestPullFromCentralRegistryImplicitRefParts to end up pulling with the
v1 protocol. This violates the assumptions behind the test. To make the
test more robust, allow a few retries if any pull ends up using the v1
protocol.
Fixes #17214