Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resilience of TestPullFromCentralRegistryImplicitRefParts #20411

Conversation

aaronlehmann
Copy link
Contributor

Sometimes transient network issues will cause
TestPullFromCentralRegistryImplicitRefParts to end up pulling with the
v1 protocol. This violates the assumptions behind the test. To make the
test more robust, allow a few retries if any pull ends up using the v1
protocol.

Fixes #17214

Sometimes transient network issues will cause
TestPullFromCentralRegistryImplicitRefParts to end up pulling with the
v1 protocol. This violates the assumptions behind the test. To make the
test more robust, allow a few retries if any pull ends up using the v1
protocol.

Fixes moby#17214

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@calavera
Copy link
Contributor

LGTM

1 similar comment
@cpuguy83
Copy link
Member

LGTM

calavera added a commit that referenced this pull request Feb 17, 2016
…ntralRegistryImplicitRefParts

Improve resilience of TestPullFromCentralRegistryImplicitRefParts
@calavera calavera merged commit e9234d8 into moby:master Feb 17, 2016
@calavera calavera deleted the strengthen-TestPullFromCentralRegistryImplicitRefParts branch February 17, 2016 23:08
@thaJeztah thaJeztah mentioned this pull request Feb 17, 2016
12 tasks
aaronlehmann added a commit to aaronlehmann/docker that referenced this pull request Mar 2, 2016
Retries after v1 fallbacks were added in moby#20411. The test still appears
to be flaky. There are two potential problems. The initial pull was not
protected against pulling from v1, so it could be giving us a different
hello-world image to compare against. Also, after experiencing a v1
fallback, we need to restore the original image before doing the next
pull, because otherwise the "Image is up to date for hello-world:latest"
message will not show up as expected.

See moby#17214.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants