Drop node.js v8 support #4164
Merged
Drop node.js v8 support #4164
+9
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
suggested changes
Jan 28, 2020
juergba
added
area: node.js
UlisesGascon
added a commit
to UlisesGascon/mocha
that referenced
this pull request
Feb 2, 2020
Suggest by @juergba at mochajs#4164
juergba
suggested changes
Feb 2, 2020
UlisesGascon
added a commit
to UlisesGascon/mocha
that referenced
this pull request
Feb 2, 2020
Suggest by @juergba at mochajs#4164
juergba
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
@UlisesGascon thank you
We will wait with merging this PR to master, Mocha is not yet ready for the next major release.
4 tasks
|
(You're everywhere, @UlisesGascon! :) |
georgeOsdDev
pushed a commit
to mobilusoss/textlint-browser-runner
that referenced
this pull request
Jun 15, 2020
cscott
added a commit
to cscott/seek-bzip
that referenced
this pull request
Jul 31, 2020
Because of the bump in mocha version to 8.0, we can no longer run tests on Node.js v8.x and below: mochajs/mocha#4164 The fibers package at version 5.0 also doesn't support Node.js v10.x or lower, although it seems to work fine in my limited testing.
cscott
added a commit
to cscott/seek-bzip
that referenced
this pull request
Jul 31, 2020
Because of the bump in mocha version to 8.0, we can no longer run tests on Node.js v8.x and below: mochajs/mocha#4164 The fibers package at version 5.0 also doesn't support Node.js v10.x or lower, although it seems to work fine in my limited testing. The commander package requires node 6 or greater: tj/commander.js#1053
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I removed support to v8 in CI and documentation as explained in #4163
Alternate Designs
N/A
Why should this be in core?
Bump minimum Nodejs version
Benefits
No need to worry about support for Node v8
Possible Drawbacks
N/A
Applicable issues
Close #4163