Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mkdirp #4222

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Update mkdirp #4222

merged 1 commit into from
Apr 18, 2020

Conversation

outsideris
Copy link
Contributor

We already update mkdirp to 0.5.4 on 6.2.4.
But 7.1.1 still have 0.5.3. So update it to 0.5.4.

This PR should land to v7.1.x only because we will use mkdirp on next v8.0.0.

Applicable issues

Close #4217

@outsideris outsideris added the type: chore generally involving deps, tooling, configuration, etc. label Apr 4, 2020
@coveralls
Copy link

coveralls commented Apr 4, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 92.97% when pulling c8b0c13 on outsideris:update-mkdirp into 7c09e63 on mochajs:release/v7.1.x.

@brettz9
Copy link

brettz9 commented Apr 6, 2020

Since this hasn't yet been merged, I might just mention there is now a mkdirp 0.5.5.

It looks like it is just removing some deprecated Node feature, but figured you might want to do it in one go.

juergba
juergba reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris could you upgrade to 0.5.5 please?

@outsideris
Copy link
Contributor Author

Ok. I will update it tonight.

@outsideris
update mkdirp
c8b0c13 
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Contributor Author

updated to 0.5.5.
Need we update mkdirp for v6.2.x as well?

juergba
juergba approved these changes Apr 18, 2020
View reviewed changes
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @outsideris.
No, I don't think we need to update v6.2.x as well.

@juergba juergba merged commit c600547 into mochajs:release/v7.1.x Apr 18, 2020
@juergba juergba added the landed-on-v7.1.x cherry-picked from master label Apr 18, 2020
@juergba juergba mentioned this pull request Apr 18, 2020
Closed
4 tasks
This was referenced Apr 28, 2020
Open
Merged
Merged
Merged
Closed
Merged
Merged
Merged
@boneskull boneskull added this to the next milestone May 21, 2020
@craigtaub
Copy link
Contributor

@boneskull removing milestone as landed already in 7.1.2.

@craigtaub craigtaub removed this from the v7.2.0 milestone May 22, 2020
@boneskull boneskull added this to the next milestone Jun 1, 2020
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Jun 1, 2020
@boneskull boneskull removed this from the next milestone Jun 1, 2020
@tpicard586 tpicard586 mentioned this pull request Jul 21, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jul 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
landed-on-v7.1.x cherry-picked from master semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@outsideris @coveralls @brettz9 @craigtaub @juergba @boneskull