add docs for parallel and root hooks #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
area: documentation
22 tasks
boneskull
force-pushed
the
boneskull/issue/2839-docs
branch
from
a312e24
to
f24c3a8
Compare
arvidOtt
approved these changes
Apr 23, 2020
arvidOtt
approved these changes
Apr 23, 2020
Merged
craigtaub
reviewed
May 14, 2020
craigtaub
approved these changes
May 14, 2020
nicojs
reviewed
May 24, 2020
|
|
||
| ## Root Hook Plugins | ||
|
|
||
| > _New in v8.0.0._ |
There was a problem hiding this comment.
Suggested change
| > _New in v8.0.0._ | |
| > _New in v7.2.0._ |
There was a problem hiding this comment.
I think we need to discuss whether we want to do this in v7.2.0 or v8.0.0. I would prefer the latter, for marketing reasons. 😜
nicojs
reviewed
May 24, 2020
docs/index.md
Outdated
| There are a (minimum of) two workarounds for this: | ||
|
|
||
| 1. `require('./setup.js')` or `import './setup.js'` at the top of every test file. Best avoided for those averse to boilerplate. | ||
| 1. _Recommended_: Define root-level hooks in a required file, using the new (also as of v8.0.0) [Root Hook Plugin](#root-hook-plugins) system. |
There was a problem hiding this comment.
Suggested change
| 1. _Recommended_: Define root-level hooks in a required file, using the new (also as of v8.0.0) [Root Hook Plugin](#root-hook-plugins) system. | |
| 1. _Recommended_: Define root-level hooks in a required file, using the new (as of v7.2.0) [Root Hook Plugin](#root-hook-plugins) system. |
outsideris
approved these changes
May 28, 2020
boneskull
force-pushed
the
boneskull/issue/2839-docs
branch
3 times, most recently
from
3dcd491
to
5100fb8
Compare
> this PR needs the changes from the `boneskull/issue/2839-11ty-changes` branch
boneskull
force-pushed
the
boneskull/issue/2839-docs
branch
from
5100fb8
to
cb80a05
Compare
|
kept these references as v8.0.0 above, and changed a reference to v7.3.0 to v8.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build might not work until that one gets merged