Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: highlight browser failures #5222

Merged
merged 25 commits into from
Oct 29, 2024
Merged

feat: highlight browser failures #5222

merged 25 commits into from
Oct 29, 2024

Conversation

mark-wiemer
Copy link
Contributor

@mark-wiemer mark-wiemer commented Oct 10, 2024 •
edited
Loading

PR Checklist

Overview

  • Change pass indicator to accessible color in light mode (dark green)
  • As soon as a test fails, add a red fail indicator and color the "failures" text red
  • As soon as all tests have a result, and none are failures, add a green pass indicator and color the "passes" text green
  • Result indicators for the root suite are the same for the result indicators for individual tests
    • Except result indicator for root suite is only pass/fail, skip for root suite will show pass for simplicity (happy to change)

image

image


image

image

@mark-wiemer mark-wiemer mentioned this pull request Oct 10, 2024
Closed
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for the overhaul! ✨

Just requesting undoing unrelated changes, to make it easier to review & not take up as much of a diff.

mocha.css Outdated Show resolved Hide resolved
lib/reporters/html.js Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP - more information needed label Oct 10, 2024
@mark-wiemer
Revert "Format html.js"
8a36f0d 
This reverts commit 8552a91.
@mark-wiemer
Copy link
Contributor Author

@JoshuaKGoldberg, ready for review :)

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for iterating on it & coming up with good ideas! 🙌

Approved - and will leave open for a bit in case anybody from @mochajs/maintenance-crew has time & interest to review.

@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author waiting on response from OP - more information needed label Oct 11, 2024
@mark-wiemer
Copy link
Contributor Author

Thanks @JoshuaKGoldberg, glad I could help. Just curious, is there an ETA for when this might be merged? Would love to see my work deployed (I am a selfish and proud man 😆)

@JoshuaKGoldberg
Copy link
Member

Haha that resonates with me. This is a UI-only change and the other maintainers haven't had time, let's ship! 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8ff4845 into mochajs:main Oct 29, 2024
105 checks passed
@github-actions github-actions bot mentioned this pull request Oct 13, 2024
Merged
@mark-wiemer mark-wiemer deleted the mark-wiemer/792-highlight-browser-failures-2 branch October 30, 2024 03:33
@averissimo averissimo mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Highlight browser failures in red
2 participants
@mark-wiemer @JoshuaKGoldberg