Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Æthelred Kerman #1459

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Æthelred Kerman #1459

merged 1 commit into from
Jul 8, 2017

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jul 6, 2017

Fix #1452.

@pleroy pleroy added the LGTM label Jul 8, 2017
@eggrobin eggrobin merged commit 57991f8 into mockingbirdnest:master Jul 8, 2017
@gbesacier
Copy link

This commit is the soruce of a NPE when accepting a contract to rescue a Kerbal from the surface of a body (which spawn the Kerbal directly in EVA).
I0711 22:07:56.336668 4520 plugin.cpp:1094] principia::ksp_plugin::internal_plugin::Plugin::ReadFromMessage @ 000007FEE10E5139 google::LogMessageFatal::~LogMessageFatal [0x000007FEE10E5138+104] (\google\glog\src\logging.cc:2034) @ 000007FEE102F03B principia__LogFatal [0x000007FEE102F03A+122] (\principia\ksp_plugin\interface.cpp:636) @ 0000000022C52F5D (No symbol) [0x0000000022C52F5C] F0711 22:08:12.940775 7488 interface.cpp:636] System.NullReferenceException: Object reference not set to an instance of an object at principia.ksp_plugin_adapter.PrincipiaPluginAdapter.UnmanageabilityReasons (.Vessel vessel) [0x00000] in <filename unknown>:0 at principia.ksp_plugin_adapter.PrincipiaPluginAdapter+<AdvanceAndNudgeVesselsAfterPhysicsSimulation>d__93.MoveNext () [0x00000] in <filename unknown>:0

Fixed with this:
if (vessel.isEVA && (vessel.evaController == null || !vessel.evaController.Ready)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants