Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions should not be recomputed at every frame #761

Closed
eggrobin opened this issue Dec 6, 2015 · 2 comments
Closed

Predictions should not be recomputed at every frame #761

eggrobin opened this issue Dec 6, 2015 · 2 comments
Assignees

Comments

@eggrobin
Copy link
Member

eggrobin commented Dec 6, 2015

Currently the prediction is recomputed at every frame, i.e., at 50 Hz. This is probably too often.

However, in order to properly take advantage of doing it less often, we'd to parallelize, which is a whole other rabbit hole (although at least MSVC now has shared_lock).

@eggrobin
Copy link
Member Author

A random thought while going through the issues: when the initial state doesn't change due to unpredictable factors (engines/collisions), we definitely shouldn't recompute the prediction often (the only change in the solution there is due to differences in integration methods between the history and prediction).
When things like engines are at play, it might make sense to (empirically) estimate the dependence on initial conditions and recompute based on that. The work on pile-ups should make the behaviour of unpacked vessels in free fall identical to that of packed vessels, so the situation should nicely split between actually no thrust and under thrust.

@pleroy
Copy link
Member

pleroy commented Apr 6, 2019

Finally fixed by #2092.

@pleroy pleroy closed this as completed Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants