Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The #[safety_constraint(...)] can be specified without deriving Arbitrary or Invariant #3396

Open
adpaco-aws opened this issue Jul 30, 2024 · 0 comments
Open

The #[safety_constraint(...)] can be specified without deriving Arbitrary or Invariant #3396

adpaco-aws opened this issue Jul 30, 2024 · 0 comments
Labels
[C] Feature / Enhancement A new feature request or enhancement to an existing feature. [E] User Experience An UX enhancement for an existing feature. Including deprecation of an existing one. Z-Contracts Issue related to code contracts

Comments

@adpaco-aws
Copy link
Contributor

adpaco-aws commented Jul 30, 2024 •
edited
Loading

As @zhassan-aws originally posted in #3270 (review)

LGTM. The only thing I'm unsure about is that Invariant is not derived automatically when the attribute is specified. There's also no warning or error message if neither Invariant or Arbitrary is derived.
@adpaco-aws adpaco-aws mentioned this issue Jul 30, 2024
Merged
@adpaco-aws adpaco-aws added [C] Feature / Enhancement A new feature request or enhancement to an existing feature. [E] User Experience An UX enhancement for an existing feature. Including deprecation of an existing one. labels Jul 31, 2024
@tautschnig tautschnig added the Z-Contracts Issue related to code contracts label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Feature / Enhancement A new feature request or enhancement to an existing feature. [E] User Experience An UX enhancement for an existing feature. Including deprecation of an existing one. Z-Contracts Issue related to code contracts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tautschnig @adpaco-aws