Make panic and assert const functions #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
Aug 26, 2022
| pub fn check_something() { | ||
| let x: u8 = if kani::any() { 3 } else { 95 }; | ||
| if x > 100 { | ||
| my_const_fn(); |
There was a problem hiding this comment.
This call isn't reachable (x > 100 is always false). The test shows you can use panic! in a const fn but I think you want to also call it, right?
There was a problem hiding this comment.
The impetus for this was definitely a compile-time error, so maybe not
There was a problem hiding this comment.
Correct, I'm intentionally not calling it so that the test passes. As Ted pointed out, compilation currently fails. The purpose of the kani::any() is to make sure the compiler doesn't optimize the function out (so we still have to codegen it).
zhassan-aws
changed the title
|
I updated the PR to make |
tedinski
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Rust allows
panic!,assert!, andassert_eq!to be used inconstfunctions. Kani's override of thepanicandassertmacros is implemented via apanicand anassertfunction that are not marked as constant, which causes an error when those macros are used in a const function. This PR fixes the issue by addingconstto thepanicandassertfunctions.Resolved issues:
Resolves #1586
Call-outs:
Testing:
How is this change tested? Added two tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.