-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts & Harnesses for wrapping_shl
#112
Contracts & Harnesses for wrapping_shl
#112
Conversation
Thank you @celinval! Another approval is required to merge this PR. @carolynzech or @feliperodri? Could you please review it? Thank you. |
Yes, a harness will only check the contract of the verified function not other functions that are annotated with contract. |
…-0011-core-nums-yenyunw-wrapping-shl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Resolves #59
Changes
wrapping_shl
(located inlibrary/core/src/num/int_macros.rs
anduint_macros.rs
)wrapping_shl
of each integer typei8
,i16
,i32
,i64
,i128
,isize
,u8
,u16
,u32
,u64
,u128
,usize
--- 12 harnesses in total.Revalidation
feature/verify-rust-std
branch.<harness_to_run>
can be eithernum::verify
to run all harnesses ornum::verify::<harness_name>
(e.g.checked_wrapping_shl_i8
) to run a specific harness.All harnesses should pass the default checks (1251 checks where 1 unreachable).
Example of the unreachable check:
Questions
requires
(andensures
) forwrapping_shl
given thatunchecked_shl
already has arequires
?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.