Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harnesses for carrying_mul #114

Merged

Conversation

lanfeima
Copy link

@lanfeima lanfeima commented Oct 15, 2024

Towards: Issue #59

Parent branch: main


Changes

  • Added macros for generating carrying_mul harnesses
  • Added harnesses for carrying_mul for the following integer types:
    • u8, u16, u32, u64

Revalidation

Per the discussion in issue #59, we have to build and run Kani from the feature/verify-rust-std branch.

To revalidate the verification results, run the following command. <harness_to_run> can be either num::verify to run all harnesses or num::verify::<harness_name> (e.g., carrying_mul_u8_small) to run a specific harness.

kani verify-std "path/to/library" \
    --harness <harness_to_run> \
    -Z unstable-options \
    -Z function-contracts \
    -Z mem-predicates

yew005 and others added 30 commits September 10, 2024 17:11
…ints' into c-0011-core-nums-junfengj-unchecked-shl
@lanfeima lanfeima requested a review from a team as a code owner October 15, 2024 23:13
@lanfeima lanfeima changed the title C 0011 core nums lanfeim carrying mul Contracts & Harnesses for carrying mul Oct 15, 2024
@lanfeima lanfeima changed the title Contracts & Harnesses for carrying mul Harnesses for carrying mul Oct 16, 2024
@lanfeima lanfeima changed the title Harnesses for carrying mul Harnesses for carrying_mul Oct 16, 2024
Copy link

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we can use wider intervals.

library/core/src/num/mod.rs Show resolved Hide resolved
library/core/src/num/mod.rs Outdated Show resolved Hide resolved
@celinval celinval self-assigned this Oct 25, 2024
Copy link

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@celinval celinval enabled auto-merge (squash) October 26, 2024 00:39
@celinval celinval merged commit c4a1f45 into model-checking:main Oct 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants