Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTP writer] sometimes indices and coordinates are messed up #2

Open
modenaxe opened this issue Feb 10, 2021 · 2 comments
Open

[VTP writer] sometimes indices and coordinates are messed up #2

modenaxe opened this issue Feb 10, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@modenaxe
Copy link
Owner

modenaxe commented Feb 10, 2021

The model is correct, but the visualization is not.

E.g. bug when fibula_r of Rajagopal model is processed

@modenaxe modenaxe changed the title [VTP writer] bug when fibula_r of Rajagopal model is processed [VTP writer] sometimes indices and coordinates are messed up Feb 17, 2021
@modenaxe modenaxe added the good first issue Good for newcomers label Mar 3, 2021
@modenaxe
Copy link
Owner Author

User Axel Koussou (not on GitHub) provided a solution:

% Thus, to fix the bug, you just have to add new_points=[]; before the loop : 

    for n = 1:size(points,1) 
        % compute torsion matrix
        TorsRotMat = RotMat(torsion_angle_func_rad(points(n,axis_ind)));
        
        % New points and axis
        new_points(n,:) = (TorsRotMat*points(n,:)')';
        new_normals(n,:) = (TorsRotMat*normals(n,:)')';
    end

modenaxe added a commit that referenced this issue Nov 18, 2021
@modenaxe
Copy link
Owner Author

working on this on branch v0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant