fix: Cleans up code with feeding pets and adds batch coin flips random check #1717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Utility.CoinFlips
for batch 50/50 successive calls to RNGUtility.RandomSample()
and instead usesShuffle()
Tip
DEVELOPER TIP
Use
Utility.CoinFlips(amount)
orUtility.CoinFlips(amount, max)
instead of looping and doingUtility.RandomBool()
multiple times. The new method is up to 60x faster.Note
DEVELOPER NOTE
Utility.RandomSample is for sampling unique
indices
and has no guard rails against duplicate valuesBenchmarks
Benchmarks between a loop calling
RandomBool()
and the newCoinFlips
method.