Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes issue with duping items and serialization, and sector lists. #1662

Merged
merged 3 commits into from
Jan 24, 2024
Merged

fix: Fixes issue with duping items and serialization, and sector lists. #1662

merged 3 commits into from
Jan 24, 2024

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Jan 22, 2024 •
edited
Loading

Important

This fixes a major issue with [dupe and serialization!

Summary

  • Fixes [dupe sharing the same SaveBuffer, causing serialization clobbering.
  • Fixes an issue with Mobile.SetLocation() -> UpdateRegion() -> OnRegionChange() -> having side effects that makes calling Map.OnMove(0 later in the SetLocation invalid.
  • Fixes disabling AutoSave not working.

@kamronbatman kamronbatman force-pushed the kbatman/fix_sector_list branch from f34ca59 to ee54277 Compare January 24, 2024 03:02
@kamronbatman kamronbatman changed the title fix: Attempts to fix sector list. fix: Fixes issue with duping items and serialization, and sector lists. Jan 24, 2024
@kamronbatman kamronbatman merged commit 3812a78 into main Jan 24, 2024
13 checks passed
@kamronbatman kamronbatman deleted the kbatman/fix_sector_list branch January 24, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kamronbatman