Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert house gumps to static/dynamic gumps #1912

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

IcculusC
Copy link
Contributor

@IcculusC IcculusC commented Aug 8, 2024

clean up and organize several house related gumps, but not the primary house management gumps (yet)

Copy link

github-actions bot commented Aug 8, 2024

Qodana for .NET

8 new problems were found

Inspection name Severity Problems
Assignment is not used 🔶 Warning 2
Possible unassigned object created by 'new' expression 🔶 Warning 1
Namespace does not correspond to file location ◽️ Notice 5

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 18 dependencies

Third-party software list

This page lists the third-party software dependencies used in ModernUO

Dependency Version Licenses
Argon2.Bindings 1.16.1 MIT
BouncyCastle.Cryptography 2.4.0 MIT
CommunityToolkit.HighPerformance 8.2.2 MIT
LibDeflate.Bindings 1.0.2.120 GPL-3.0-only
MailKit 4.7.1.1 MIT
Microsoft.Extensions.FileSystemGlobbing 8.0.0 MIT
MimeKit 4.7.1 MIT
ModernUO.Serialization.Annotations 2.9.1 GPL-3.0-only
ModernUO.Serialization.Generator 2.11.3 GPL-3.0-only
Nerdbank.GitVersioning 3.6.139 MIT
PollGroup 1.5.1 BSD-3-Clause
Serilog.Sinks.Async 2.0.0 Apache-2.0
Serilog.Sinks.Console 6.0.0 Apache-2.0
Serilog 4.0.1 Apache-2.0
System.Formats.Asn1 8.0.1 MIT
System.IO.Hashing 8.0.0 MIT
System.Security.Cryptography.Pkcs 8.0.0 MIT
Zstd.Binaries 1.6.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@IcculusC IcculusC marked this pull request as ready for review August 8, 2024 02:21
@kamronbatman kamronbatman changed the title fix and organize House related gumps fix: Convert house gumps to static/dynamic gumps Aug 8, 2024
@kamronbatman kamronbatman force-pushed the fix-organize-house-gumps branch from 16c8938 to b966c9b Compare August 10, 2024 17:52
@kamronbatman kamronbatman merged commit 12a75d3 into main Aug 10, 2024
12 of 13 checks passed
@kamronbatman kamronbatman deleted the fix-organize-house-gumps branch August 10, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants