Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure server listing address is used when set in config #1960

Merged

Conversation

jkappers
Copy link
Contributor

@jkappers jkappers commented Sep 21, 2024

This is important for container management hosts where the server container doesn't have access to the host IP.

The following scenarios were tested:

scenario public ip private ip
Docker and client on same host Y Y
Docker and client on different hosts, same network Y Y
Docker and client on different hosts, different network Y N/A

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2024

CLA assistant check
All committers have signed the CLA.

kamronbatman
kamronbatman previously approved these changes Sep 21, 2024
@kamronbatman kamronbatman merged commit 3a3c651 into modernuo:main Sep 22, 2024
11 of 13 checks passed
Eaprime1 added a commit to Eaprime1/ModernUO that referenced this pull request Sep 24, 2024
fix: Ensure server listing address is used when set in config (modernuo#1960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants