Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RPyC tracing to folster further speed tuning #1831

Closed
vnlitvinov opened this issue Jul 27, 2020 · 0 comments · Fixed by #1843
Closed

Implement RPyC tracing to folster further speed tuning #1831

vnlitvinov opened this issue Jul 27, 2020 · 0 comments · Fixed by #1843
Assignees
@vnlitvinov
Labels
new feature/request 💬 Requests and pull requests for new features
Milestone
0.8.0

Comments

@vnlitvinov
Copy link
Collaborator

RPyC requests are almost impossible to analyze using usual performance profilers as they don't take a lot of time (but add quite a bunch of latency), and for efficient analysis it is needed to know what method of which object was called, and what arguments it got.

So we need some means to trace the RPyC execution and to analyze the generated trace.
@vnlitvinov vnlitvinov added the new feature/request 💬 Requests and pull requests for new features label Jul 27, 2020
@vnlitvinov vnlitvinov added this to the 0.8.0 milestone Jul 27, 2020
@vnlitvinov vnlitvinov self-assigned this Jul 28, 2020
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Add some rpyc tracing
f4a6ce4 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Add more rpyc tracing
2fa0ac6 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Add a method to create separate RPyC "loggin…
742cad1 
…g context"

Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Format stuff by black
c300a31 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Move rpyc tracing under a variable
fa74af8 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Stringify logged args safer
525666f 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Move TracingWrappingConnection to separate p…
06c112d 
…ackage

Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Add simple rpyc trace parser
e75582e 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Improve rpyc trace parser
e374be7 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Apply black and fix flake8 issues
9e5b082 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
@vnlitvinov vnlitvinov mentioned this issue Jul 28, 2020
Merged
6 tasks
vnlitvinov added a commit to vnlitvinov/modin that referenced this issue Jul 28, 2020
@vnlitvinov
FEAT-modin-project#1831: Ignore print() rule for trace parser
d49b1c0 
Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
anmyachev pushed a commit that referenced this issue Jul 29, 2020
@vnlitvinov
FEAT-#1831: Add optional RPyC tracing and a simple trace parser (#1843)
9ed8e06 
For details see #1843 

Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@vnlitvinov @aregm
FEAT-modin-project#1831: Add optional RPyC tracing and a simple trace…
7966a86 
… parser (modin-project#1843)

For details see modin-project#1843 

Signed-off-by: Vasilij Litvinov <vasilij.n.litvinov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vnlitvinov vnlitvinov

Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Add optional RPyC tracing and a simple trace parser vnlitvinov/modin
1 participant
@vnlitvinov