Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all environment variables in a single file #1832

Closed
vnlitvinov opened this issue Jul 28, 2020 · 1 comment
Closed

Consolidate all environment variables in a single file #1832

vnlitvinov opened this issue Jul 28, 2020 · 1 comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase documentation 📜 Updates and issues with the documentation

Comments

@vnlitvinov
Copy link
Collaborator

There are quite a few environment variables that affect Modin behaviour.

They are now scattered throughout the code, which negatively impacts discoverability by users.
I propose to move them all to a single file, each to a separate function. This would allow to unify how variables are processed and sanitized and provide a common place to document them.

Reference: #1816
@vnlitvinov vnlitvinov added documentation 📜 Updates and issues with the documentation Code Quality 💯 Improvements or issues to improve quality of codebase labels Jul 28, 2020
@vnlitvinov
Copy link
Collaborator Author

Resolved by #2189 (was accidentally duplicated as #2059)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase documentation 📜 Updates and issues with the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vnlitvinov