Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'sort_index' do not consider 'axis` parameter in case of MultiIndex #1857

Closed
dchigarev opened this issue Jul 29, 2020 · 0 comments · Fixed by #1858
Closed

'sort_index' do not consider 'axis` parameter in case of MultiIndex #1857

dchigarev opened this issue Jul 29, 2020 · 0 comments · Fixed by #1858
Assignees
@dchigarev
Labels
bug 🦗 Something isn't working
Milestone
0.8.0

Comments

@dchigarev
Copy link
Collaborator

Describe the problem

In a current sort_index implementation axis parameter do not consider in case of MultiIndex

modin/modin/backends/pandas/query_compiler.py

Lines 1559 to 1568 in 79be7d6

if level is not None or (
(axis == 0 and isinstance(self.index, pandas.MultiIndex))
or (axis == 1 and isinstance(self.columns, pandas.MultiIndex))
):
return self.default_to_pandas(
pandas.DataFrame.sort_index,
level=level,
sort_remaining=sort_remaining,
**kwargs
)

@dchigarev dchigarev added the bug 🦗 Something isn't working label Jul 29, 2020
@dchigarev dchigarev added this to the 0.8.0 milestone Jul 29, 2020
@dchigarev dchigarev self-assigned this Jul 29, 2020
dchigarev added a commit to dchigarev/modin that referenced this issue Jul 29, 2020
@dchigarev
FIX-modin-project#1857: make 'sort_index' consider axis parameter
2ecc3c5 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev mentioned this issue Jul 29, 2020
Merged
6 tasks
devin-petersohn pushed a commit that referenced this issue Jul 29, 2020
@dchigarev
FIX-#1857: make 'sort_index' consider axis parameter (#1858)
dcd3674 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@dchigarev @aregm
FIX-modin-project#1857: make 'sort_index' consider axis parameter (mo…
df3f1d4 
…din-project#1858)

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchigarev dchigarev

Labels
bug 🦗 Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

FIX-#1857: make 'sort_index' consider axis parameter dchigarev/modin
1 participant
@dchigarev