Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Avoid index access in DataFrame.insert with scalar value #1941

Closed
ienkovich opened this issue Aug 21, 2020 · 0 comments · Fixed by #1942
Closed

[REFACTOR] Avoid index access in DataFrame.insert with scalar value #1941

ienkovich opened this issue Aug 21, 2020 · 0 comments · Fixed by #1942
Assignees
@ienkovich
Labels
HDK Related to HDK (OmniSci successor) engine or backend

Comments

@ienkovich
Copy link
Collaborator

Currently, DataFrame.insert method expands scalar values to array accessing index to get its length. This should be moved to backend to allow lazy execution.
@ienkovich ienkovich added the HDK Related to HDK (OmniSci successor) engine or backend label Aug 21, 2020
@ienkovich ienkovich self-assigned this Aug 21, 2020
@ienkovich ienkovich mentioned this issue Aug 21, 2020
Merged
6 tasks
YarShev pushed a commit that referenced this issue Aug 25, 2020
@ienkovich
REFACTOR-#1941: move index access from DataFrame.insert to backend (#…
82849bb 
…1942)

Signed-off-by: ienkovich <ilya.enkovich@intel.com>
aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
@ienkovich @aregm
REFACTOR-modin-project#1941: move index access from DataFrame.insert …
49ed9cc 
…to backend (modin-project#1942)

Signed-off-by: ienkovich <ilya.enkovich@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ienkovich ienkovich

Labels
HDK Related to HDK (OmniSci successor) engine or backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REFACTOR-#1941: move index access from DataFrame.insert to backend
1 participant
@ienkovich