Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ray 0.8.7 #1958

Closed
crypdick opened this issue Aug 25, 2020 · 5 comments · Fixed by #1966
Closed

Upgrade to Ray 0.8.7 #1958

crypdick opened this issue Aug 25, 2020 · 5 comments · Fixed by #1966
Labels
new feature/request 💬 Requests and pull requests for new features
Milestone

Comments

@crypdick
Copy link

I am experiencing an issue with Ray which is fixed in 0.8.7; however, Modin has pinned the Ray version to 0.8.6 here. Can we please update the dependency?

@crypdick crypdick added the new feature/request 💬 Requests and pull requests for new features label Aug 25, 2020
@devin-petersohn
Copy link
Collaborator

Thanks @crypdick for the report, yes we should update it. I took last week off and am still catching up. You can install Ray 0.8.7 and bypass this in the short term with the following:

import os
os.environ["MODIN_ENGINE"] = "ray"  # set this first
import modin.pandas as pd  # then import

You can also set the environment variable outside of python as well.

On a more general note, it is probably time to relax the pin. I think the ray API has stabilized to the point where we can use a >= instead of a hard pin.

@devin-petersohn devin-petersohn added this to the 0.8.1 milestone Aug 25, 2020
@crypdick
Copy link
Author

@devin-petersohn here's what I get when I try that:

    import modin.pandas as mpd
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/modin/pandas/__init__.py", line 170, in <module>
    execution_engine.subscribe(_update_engine)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/modin/__init__.py", line 93, in subscribe
    callback(self)
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/modin/pandas/__init__.py", line 113, in _update_engine
    initialize_ray()
  File "/home/ubuntu/anaconda3/lib/python3.7/site-packages/modin/engines/ray/utils.py", line 147, in initialize_ray
    lru_evict=True,
TypeError: init() got an unexpected keyword argument 'include_webui'

@binarycrayon
Copy link
Contributor

I have the same need so added a pr, thanks!

@binarycrayon
Copy link
Contributor

@crypdick Ray community recently decided to rename webui to dashboard, so include_webui became include_dashboard. detail see this pr ray-project/ray#8999

I've mitigated that kwarg in my pr (basically changed to include_dashboard=False)

devin-petersohn pushed a commit that referenced this issue Sep 1, 2020
Signed-off-by: Yudi Xue <10211+binarycrayon@users.noreply.github.com>
@crypdick
Copy link
Author

crypdick commented Sep 8, 2020

Just figured out how to pin Modin to the latest master SHA, in case it's helpful to anyone:

pip install git+https://github.com/modin-project/modin.git@0c0b6f64bc9c6afc1267fe9fc703a0e30d783f96
pip install  "modin[ray] @ git+https://github.com/modin-project/modin.git@0c0b6f64bc9c6afc1267fe9fc703a0e30d783f96"

(haven't gotten this to work with requirements.txt)

aregm pushed a commit to aregm/modin that referenced this issue Sep 16, 2020
Signed-off-by: Yudi Xue <10211+binarycrayon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants