Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not sort indices multiple times at internal .mask() #4138

Closed
dchigarev opened this issue Feb 1, 2022 · 1 comment · Fixed by #4140
Closed

Do not sort indices multiple times at internal .mask() #4138

dchigarev opened this issue Feb 1, 2022 · 1 comment · Fixed by #4140
Assignees
@dchigarev
Labels
Performance 🚀 Performance related issues and pull requests.

Comments

@dchigarev
Copy link
Collaborator

During PandasDataframe.mask() flow the passed indices are being sorted multiple times: [1] [2] [3], this negatively affects the performance, especially if the amount of indices to take is huge (for example boolean masking with a lot of True values).

We should eliminate repeating sort operations.
@dchigarev dchigarev added the Performance 🚀 Performance related issues and pull requests. label Feb 1, 2022
@dchigarev dchigarev self-assigned this Feb 1, 2022
@dchigarev
Copy link
Collaborator Author

this issue is a part of #3844

@dchigarev dchigarev mentioned this issue Feb 1, 2022
Merged
8 tasks
dchigarev added a commit to dchigarev/modin that referenced this issue Feb 1, 2022
@dchigarev
FIX-modin-project#4138: optimize internal '.mask()' flow
01b8977 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev mentioned this issue Feb 1, 2022
Closed
YarShev pushed a commit that referenced this issue Feb 10, 2022
@dchigarev
FIX-#4138, FIX-#4009: optimize internal '.mask()' flow (#4140)
c5f5068 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchigarev dchigarev

Labels
Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#4138, FIX-#4009: optimize internal '.mask()' flow dchigarev/modin
1 participant
@dchigarev