Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: DeprecationWarning from using np.bool #4570

Closed
NickCrews opened this issue Jun 11, 2022 · 0 comments · Fixed by #4571
Closed

BUG: DeprecationWarning from using np.bool #4570

NickCrews opened this issue Jun 11, 2022 · 0 comments · Fixed by #4571

Comments

@NickCrews
Copy link
Contributor

I get:

../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1350: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1351: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1356: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1376: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1378: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1383: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1384: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1385: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1386: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1387: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1388: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1389: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1390: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1391: 1 warning
../../../Library/Application Support/hatch/env/virtual/mismo-5Vu_DQpX/mismo/lib/python3.10/site-packages/modin/core/storage_formats/pandas/query_compiler.py:1412: 1 warning
  DeprecationWarning: `np.bool` is a deprecated alias for the builtin `bool`. To silence this warning, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Simple follow up patch to follow.
@NickCrews NickCrews changed the title DeprecationWarning from using np.bool BUG: DeprecationWarning from using np.bool Jun 11, 2022
@NickCrews NickCrews mentioned this issue Jun 11, 2022
Merged
8 tasks
NickCrews added a commit to NickCrews/modin that referenced this issue Jun 11, 2022
@NickCrews
FIX-modin-project#4570: Replace np.bool -> np.bool_
03e0203 
I was getting:
  DeprecationWarning: `np.bool` is a deprecated alias for the builtin `bool`. To silence this warning, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

I assume that this is the correct substitution, instead of chaning to a simple `bool`, but I don't understand what this code does here, so I may be wrong.

Signed-off-by: Nick Crews <nicholas.b.crews@gmail.com>
NickCrews added a commit to NickCrews/modin that referenced this issue Jun 14, 2022
@NickCrews @devin-petersohn
FIX-modin-project#4570: Just use np.bool_ consistently
f415df7 
See modin-project#4571

Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
RehanSD added a commit that referenced this issue Jun 16, 2022
@NickCrews @devin-petersohn @RehanSD
FIX-#4570: Replace np.bool -> np.bool_ (#4571)
dbc78a9 
Signed-off-by: Nick Crews <nicholas.b.crews@gmail.com>
Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
Co-authored-by: Rehan Durrani <rehan@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#4570: Replace np.bool -> np.bool_ NickCrews/modin
1 participant
@NickCrews