Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Unify select_dtypes logic #4576

Closed
NickCrews opened this issue Jun 14, 2022 · 1 comment
Closed

REF: Unify select_dtypes logic #4576

NickCrews opened this issue Jun 14, 2022 · 1 comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase External Pull requests and issues from people who do not regularly contribute to modin P2 Minor bugs or low-priority feature requests

Comments

@NickCrews
Copy link
Contributor

NickCrews commented Jun 14, 2022 •
edited
Loading

We currently have duplicated logic to select dtypes in in base.describe() vs dataframe.select_dtypes()

Looking at how pandas does this, their describe() uses select_dtypes() so that those two methods are guaranteed to have the same behavior and always be in sync. Do we want to / can we do the same thing? Or somehow merge that logic together so they both use the same helper functions?

Originally posted by @NickCrews in #4571 (comment)
@NickCrews NickCrews changed the title REF: REF: Unify select_dtypes logic Jun 14, 2022
@vnlitvinov vnlitvinov added Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests labels Sep 9, 2022
@anmyachev anmyachev added the External Pull requests and issues from people who do not regularly contribute to modin label Apr 19, 2023
@anmyachev
Copy link
Collaborator

describe reuses the logic of select_dtypes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase External Pull requests and issues from people who do not regularly contribute to modin P2 Minor bugs or low-priority feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickCrews @vnlitvinov @anmyachev